Re: [RFC PATCH] debugfs - yet another in-kernel file system
From: Jörn Engel
Date: Fri Dec 10 2004 - 13:31:51 EST
On Fri, 10 December 2004 09:35:56 -0800, Greg KH wrote:
> On Fri, Dec 10, 2004 at 06:21:26PM +0100, J?rn Engel wrote:
> > On Thu, 9 December 2004 16:50:56 -0800, Greg KH wrote:
> > > +#include <linux/config.h>
> > > +#include <linux/module.h>
> > > +#include <linux/fs.h>
> > > +#include <linux/mount.h>
> > > +#include <linux/pagemap.h>
> > > +#include <linux/init.h>
> > > +#include <linux/namei.h>
> > I like to sort the above alphabetically. Shouldn't matter, but it
> > looks neat and since there is no other natural order...
> Well config.h should be first. After that, sometimes it matters, but
> usually not.
I buy the config.h point. For the rest, I actually like to receive
the breakage when order matters. It shouldn't matter, so there goes
> Just being "correct" :)
> I don't think they would want special nodes, but hey, let's not prevent
> anyone from doing anything. If some looney person wants to make device
> nodes in debugfs, then they deserve the ridicule they will get when
> doing it...
Thought so. But hey, there may be valid reasons to do so. And if
there are, I'd like to hear the story.
When people work hard for you for a pat on the back, you've got
to give them that pat.
-- Robert Heinlein
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/