swsusp bugfixes: fix memory leak

From: Pavel Machek
Date: Sat Dec 11 2004 - 10:48:03 EST


This fixes memory leak when we are low on memory during
suspend. Ouch and nr_needed_pages is only used twice, and only written
:-(. I guess that can wait for 2.6.10. Please apply,

--- clean/kernel/power/swsusp.c 28 Oct 2004 15:21:34 -0000 1.29
+++ linux/kernel/power/swsusp.c 10 Dec 2004 21:35:59 -0000
@@ -786,12 +768,13 @@

int suspend_prepare_image(void)
- unsigned int nr_needed_pages = 0;
+ unsigned int nr_needed_pages;
int error;

pr_debug("swsusp: critical section: \n");
if (save_highmem()) {
printk(KERN_CRIT "Suspend machine: Not enough free pages for highmem\n");
+ restore_highmem();
return -ENOMEM;

People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/