Re: [PATCH 2.4] serial closing_wait and close_delay

From: Ian Abbott
Date: Thu Dec 16 2004 - 08:25:23 EST

On 13/12/04 11:56, Marcelo Tosatti wrote:
On Tue, Nov 30, 2004 at 07:06:02PM +0000, Ian Abbott wrote:
* In several drivers, the closing_wait and close_delay values are written to a struct serial_state by TIOCSSERIAL, but the values used in the close routine are read from a struct async_struct, with no code to transfer of values between the two structures. My patch ignores the members in struct async_struct and uses the values from struct serial_state.

Can you please split this part of the patch? (and send as a separate patch
to me CC Alan and Russell).

Okay, I'm about to send that. By the way, while going through my original patch, I noticed that one of its changes to drivers/char/moxa.c was incorrect. Line 671 of the original used a fixed 30 second timeout. My change replaced that to use closing_wait but I got the name of the variable wrong; it should have been 'ch', not 'info'. My split-off patch doesn't change moxa.c.

-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at