On Dunnersdag 16 Dezember 2004 01:02, Jesper Juhl wrote:I guess you have a point. I won't submit more of these through LKML but will stick to working with maintainers.
If these patches are generally acceted then I think it would make
make a small addition to Documentation/CodingStyle mentioning the
form of return statements, so we (hopefully) won't have to do cleanups
like this too often in the future.
Below I've included a proposed patch adding such a bit to CodingStyle.
I think the change in Documentation/CodingStyle is useful, even though I
don't really like changing all the existing code without going through
the respective maintainers.
This is basically the same category as the first three chapters of
CodingStyle. It's not nice to read, but there is no real problem in the code. Think of these issues as whitespace fixes: you are making the job
harder for code maintainers for very little gain. I would suggest that
you submit these patches only to the code maintainers, not to the
Patch Monkey or Andrew.
Or even better, change scripts/Lindent to do the change automatically
code that it is used on, if that can be done in a reliable way.