Re: [PATCH] debugfs for 2.6.10-rc3

From: Greg KH
Date: Thu Dec 16 2004 - 20:24:48 EST


On Fri, Dec 17, 2004 at 01:47:39AM +0100, Alexander Nyberg wrote:
> On Thu, 2004-12-16 at 13:36 -0800, Greg KH wrote:
> > I've added debugfs to my bk driver tree (located at
> > bk://kernel.bkbits.net/gregkh/linux/driver-2.6) so it will show up in
> > the next -mm release. For those who want to see the patch version, or
> > want to put it in any other kernel tree (Fedora perhaps?) I've included
> > it below. I haven't added the kobject interface yet, I'll try to get to
> > that next week.
> >
> > thanks,
> >
> > greg k-h
> >
> > ----------------------------
> >
> > debugfs: add debugfs
> >
> > debugfs is a filesystem that is just for debug data.
> > Start moving stuff out of proc and sysfs now :)
>
> Hi Greg
>
> Is there any reason why this shouldn't be buildable as module? I saw no
> apparent reason and added "|| defined(MODULE)" to debugfs.h and made the
> Kconfig option tristate. This allowed it to be built as a working module
> (yay, i didn't have to restart to try it out!).

If debugfs calls are used by any code that is built into the kernel,
then the build would fail if debugfs is a module. As that would soon
get _real_ messy from a Kbuild standpoint, I took the easy way out and
just made it a Y/N type option :)

> Also I saw there was no debugfs_create_u64() for us on 64bit machines ;)

If you have a need for it, I'll be glad to add it :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/