Re: Cannot mount multi-session DVD with ide-cd, must use ide-scsi

[Jens Axboe]

On Fri, Dec 17 2004, Andrew Morton wrote:
> Rashkae <rashkae@xxxxxxxxxxxxxxx> wrote:
> >
> > I can confirm that Linux Kerenl 2.6.9 still cannot mount a
> >  multi-session DVD if the last session starts at > 2.2 GB.  The
> >  only information on this problem I can find is here:
> > 
> >  http://marc.theaimsgroup.com/?l=linux-kernel&m=108827602322464&w=2
> > 
> >  Is there a patch anywhere to address this?
> 
> Please test this.  Jens, could you please check this one?

It looks fine for the case where the tocentry read suceeds, but you
should change the fallback assignment to be lba based as well I think.

> diff -puN drivers/ide/ide-cd.c~ide-cd-unable-to-read-multisession-dvds drivers/ide/ide-cd.c
> --- 25/drivers/ide/ide-cd.c~ide-cd-unable-to-read-multisession-dvds	2004-12-11 22:14:16.629388296 -0800
> +++ 25-akpm/drivers/ide/ide-cd.c	2004-12-11 22:14:16.635387384 -0800
> @@ -2353,7 +2353,7 @@ static int cdrom_read_toc(ide_drive_t *d
>  	/* Read the multisession information. */
>  	if (toc->hdr.first_track != CDROM_LEADOUT) {
>  		/* Read the multisession information. */
> -		stat = cdrom_read_tocentry(drive, 0, 1, 1, (char *)&ms_tmp,
> +		stat = cdrom_read_tocentry(drive, 0, 0, 1, (char *)&ms_tmp,
>  					   sizeof(ms_tmp), sense);
>  		if (stat) return stat;
>  	} else {

it's the bottom part of that else.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/