Re: [patch 2.6.10-rc3 1/4] agpgart: allow multiple backends to be initialized
From: Christoph Hellwig
Date: Sat Dec 18 2004 - 09:49:30 EST
On Fri, Dec 17, 2004 at 12:55:59PM -0800, Mike Werner wrote:
> This new version reduces the number of changes required by users of the agpgart
> such as drm to support the new api for multiple agp bridges.
> The first patch doesn't touch any platform specific files and all current platform
> gart drivers will just work the same as they do now since the global
> agp_bridge is still supported as the default bridge.
The agp_bridge_find function pointer is bogus, that way you can only support
one backend at a time. I'm not really sure how to do that propery, best have
the generic code walk down the pci device parent chain until it finds an AGP
bridge and allow drivers that don't present their bridges as PCI devices to
supply additional ways to search.
Most other bits of the patch are fine, but in either case you first need to
change the agp bridge driver API to take a struct agp_bridge_data in every
method, else all these changes don't make sense at all.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/