Re: [RFC] [PATCH] cdu31a - more fixes

From: Christoph Hellwig
Date: Sun Dec 19 2004 - 08:37:30 EST

> +#define RETURN_UP(retval) do {up(&sony_sem); return (retval);} while(0)

Please don't use such obsfucation macros. Instead use gotos in the
functions to haev a single exit path that releases the lock.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at