Re: [PATCH] pcxx: replace cli()/sti() withspin_lock_irqsave()/spin_unlock_irqrestore()

From: Alan Cox
Date: Mon Dec 20 2004 - 11:07:08 EST

On Gwe, 2004-12-17 at 22:34, James Nelson wrote:
> - save_flags(flags);
> - cli();
> + spin_lock_irqsave(&pcxx_lock, flags);
> del_timer_sync(&pcxx_timer);

Not safe if the lock is grabbed by the timer between the lock and the
irqsave as it will spin on another cpu and the timer delete will never

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at