bug in smbfs source code?

From: Julian Pellico
Date: Mon Dec 20 2004 - 21:16:45 EST


I've been looking over the smbfs kernel code with someone at work and
he thinks there might be a bug.

In fs/smbfs/proc.c function smb_build_path (I won't give exact line
numbers 'cause I'm looking at 2.5.6), the first call of the form:

len = server->ops->convert(path, maxlen-2,
entry->d_name.name, entry->d_name.len,
server->local_nls, server->remote_nls);

We think that maxlen-2 should be
maxlen - (2 << unicode)

Does anyone agree?

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/