Re: [PATCH] add PCI API to sysfs

From: Benjamin Herrenschmidt
Date: Tue Dec 21 2004 - 02:12:11 EST

> > +static int mmap(struct file *file, struct vm_area_struct *vma)
> > +{

Also, just a style comment: I dislike when functions have such a
"generic" name like mmap. I'd _much_ prefer something like pcisysfs_mmap
or something like that. The simple name makes it confusing in and thus when debugging.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at