Re: [PATCH] add mmap support to struct bin_attribute files

From: Greg KH
Date: Tue Dec 21 2004 - 12:48:19 EST

On Tue, Dec 21, 2004 at 09:32:54AM -0800, Jesse Barnes wrote:
> * Copyright (c) 2001,2002 Patrick Mochel
> + * Copyright (c) 2004 Silicon Graphics, Inc.

Minor nit, some copyright lawyers I know say it should be (C) not (c),
for what it's worth...

> +struct vm_area_struct; /* circular dependencies? */

Drop the comment :)

> struct bin_attribute {
> struct attribute attr;
> size_t size;
> + void *private;

Why the private pointer? Don't you get everything you need in the
kobject itself?


greg k-h
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at