Re: PATCH: 2.6.10 - Still mishandles volumes without geometry data

[Andries Brouwer]

On Wed, Dec 29, 2004 at 02:36:11PM +0000, Alan Cox wrote:

> > > -	printk(", CHS=%d/%d/%d", 
> > > -	       drive->bios_cyl, drive->bios_head, drive->bios_sect);
> > > +	if(drive->bios_cyl)
> > > +		printk(", CHS=%d/%d/%d", 
> > > +			drive->bios_cyl, drive->bios_head, drive->bios_sect);
> > 
> > Reasonable. (But s/if(/if (/ .)
> > On the other hand, I like the "CHS=0/0/0" - it makes very clear what is wrong
> > in case lilo or so has geometry problems.
> 
> 0/0/0 is valid in these cases - would it be better if it printed
> something else instead for that situation ("No physical geometry, ")
> perhaps ?

But it is not the "physical geometry" (whatever that may be) that is printed.
Not drive->head but drive->bios_head. It is easiest just to leave it.

Andries
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/