RE: [PATCH] SATA support for Intel ICH7 - 2.6.10

[Gaston, Jason D]

Thanks Ulrich!

I will edit and resubmit the patch with &&.

Jason


>-----Original Message-----
>From: Ulrich Drepper [mailto:drepper@xxxxxxxxx]
>Sent: Wednesday, December 29, 2004 5:19 PM
>To: Gaston, Jason D
>Cc: Jeff Garzik; linux-kernel@xxxxxxxxxxxxxxx
>Subject: Re: [PATCH] SATA support for Intel ICH7 - 2.6.10
>
>On Wed, 29 Dec 2004 16:13:41 -0800, Gaston, Jason D
><jason.d.gaston@xxxxxxxxx> wrote:
>>         } else {
>> -               WARN_ON(ich != 6);
>> +               WARN_ON((ich != 6) || (ich != 7));
>
>This cannot be right.  Every number is either != 6 or != 7.  You want
&&.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/