Re: [3/8] kill gen_init_cpio.c printk() of size_t warning

[linux-os]

On Mon, 3 Jan 2005, William Lee Irwin III wrote:

> The rest of gen_init_cpio.c seems to cast the result of strlen() to
> handle this situation, so this patch follows suit while killing off
> size_t -related printk() warnings.
>
> Signed-off-by: William Irwin <wli@xxxxxxxxxxxxxx>
>
> Index: mm1-2.6.10/usr/gen_init_cpio.c
> ===================================================================
> --- mm1-2.6.10.orig/usr/gen_init_cpio.c	2005-01-03 06:45:53.000000000 -0800
> +++ mm1-2.6.10/usr/gen_init_cpio.c	2005-01-03 08:11:18.000000000 -0800
> @@ -86,7 +86,7 @@
> 		0,			/* minor */
> 		0,			/* rmajor */
> 		0,			/* rminor */
> -		(unsigned)strlen(name) + 1, /* namesize */
> +		(unsigned)strlen(name)+1, /* namesize */
> 		0);			/* chksum */
> 	push_hdr(s);
> 	push_rest(name);
> @@ -112,7 +112,7 @@
> 		(long) gid,		/* gid */
> 		1,			/* nlink */
> 		(long) mtime,		/* mtime */
> -		strlen(target) + 1,	/* filesize */
> +		(unsigned)strlen(target)+1, /* filesize */
> 		3,			/* major */
> 		1,			/* minor */
> 		0,			/* rmajor */
> -

The problem is that '1' is an int, not an unsigned int.
So, the correct fix is:

		strlen(target) + 1U;

Cheers,
Dick Johnson
Penguin : Linux version 2.6.9 on an i686 machine (5537.79 BogoMips).
 Notice : All mail here is now cached for review by Dictator Bush.
                 98.36% of all statistics are fiction.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/