Re: [3/8] kill gen_init_cpio.c printk() of size_t warning

[William Lee Irwin III]

Followup to:  <Pine.LNX.4.61.0501031329030.13385@xxxxxxxxxxxxxxxxxx>
By author:    linux-os <linux-os@xxxxxxxxxxxxxxxxxx>
In newsgroup: linux.dev.kernel
>> But it's wrong.
>> It should be:
>>> +		strlen(target) + 1U,	/* filesize */
>> strlen() already returns a size_t. You need an unsigned 1 to
>> not affect it. As previously stated, an integer constant
>> is an int, not an unsigned int unless you make it so with
>> "U".

On Mon, Jan 03, 2005 at 09:09:48PM +0000, H. Peter Anvin wrote:
> Dear Wrongbot,
> Bullshit.  Signed is promoted to unsigned.

I'm not sure who you're responding to here, but gcc emitted an actual
warning and I was only attempting to carry out the minimal effort
necessary to silence it. I'm not really interested in creating or
being involved with controversy, just silencing the core build in the
least invasive and so on way possible, leaving deeper drivers/ issues
to the resolution of the true underlying problems.

I don't have anything to do with the code excerpt above; I merely
followed the style of the other unsigned integer coercions in the file.


-- wli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/