Re: [PATCH] get/set FAT filesystem attribute bits

[H. Peter Anvin]

OGAWA Hirofumi wrote:

> "H. Peter Anvin" <hpa@xxxxxxxxx> writes:
>
>
> > -	inode->i_ctime.tv_nsec = de->ctime_ms * 1000000;
> > -	MSDOS_I(inode)->i_ctime_ms = de->ctime_ms;
> > +	inode->i_ctime.tv_nsec = de->ctime_ms * 1000000U;
>
> Actually, the ->ctime_ms is not mili seconds. The valid range is 0-199 (*10ms).
> (And ->ctime is started from 2 seconds)

D'oh!  They probably should be renamed _cs (centiseconds ;)

> > -		raw_entry->ctime_ms = MSDOS_I(inode)->i_ctime_ms; /* use i_ctime.tv_nsec? */
> > +		raw_entry->ctime_ms = inode->i_ctime.tv_nsec / 1000000U;
>
>
> BTW, do you already have any plan to use this ioctls?

Yes, I wanted to use them for the syslinux installer.

	-hpa

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/