Re: [RFC] [PATCH] merge *_vm_enough_memory()s into a common helper

From: Hugh Dickins
Date: Wed Jan 05 2005 - 08:19:52 EST


On Wed, 5 Jan 2005, Christoph Hellwig wrote:
> On Tue, Jan 04, 2005 at 03:48:33PM -0600, Serge E. Hallyn wrote:
> > The attached patch introduces a __vm_enough_memory function in
> > security/security.c which is used by cap_vm_enough_memory,
> > dummy_vm_enough_memory, and selinux_vm_enough_memory. This has
> > been discussed on the lsm mailing list.
> >
> > Are there any objections to or comments on this patch?
>
> Maybe this function should go into mm/ ?

My thought exactly: yes, please do move it back into mm/,
where it started out before security/ came into the picture.

But where in mm? I suppose either mm/mmap.c where vm_committed_space
is still declared, or (that strange ragbag) mm/swap.c where the
CONFIG_SMP vm_acct_memory is.

Hugh

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/