Re: [PATCH] macros to detect existance of unlocked_ioctl and ioctl_compat

[Greg KH]

On Thu, Jan 06, 2005 at 10:09:21PM +0100, Petr Vandrovec wrote:
> On Thu, Jan 06, 2005 at 09:44:31PM +0100, Andi Kleen wrote:
> > On Thu, Jan 06, 2005 at 11:59:59AM -0800, David S. Miller wrote:
> > > On Thu, 6 Jan 2005 20:51:44 +0100
> > > Andi Kleen <ak@xxxxxxx> wrote:
> > > 
> > > > DaveM can probably give you more details since he tried unsucessfully
> > > > to make it work. I think the problem is that there is no enough
> > > > information for the compat layer to convert everything.
> > > 
> > > When the usbfs async stuff writes back the status, we are no
> > > longer within the original syscall/ioctl execution any more,
> > > therefore we don't know if we're doing this for a compat task
> > > or not.

Ick, yeah, now I remember...

> P.S.:  When designing new API, please do not make it unnecessary complicated.
> USB video needs rather large bandwidth and low latency, so please no ASCII
> strings, and scatter-gather aware API helps a bit...

In measurements published on linux-usb-devel, pure userspace calls using
the current usbfs code generated almost full bandwidth usage (within the
hardware limits).  So adding the scatter-gather api interface to usbfs
wouldn't really provide that much benefit.

And, we can always use help in designing such an API, if you could find
someone at your company to help us out in doing so... :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/