Re: [2.6.10-bk7] Oops: ide_dma_timeout_retry

From: Simon Kirby
Date: Thu Jan 06 2005 - 17:21:24 EST


On Thu, Jan 06, 2005 at 08:18:22PM +0000, Alan Cox wrote:

> Don't think it got discussed on l/k. Dunno if its in the 2.6.10bk code
> yet either
>
> rq->errors = 0;
>
> if (!rq->bio)
> goto out;
>
> rq->sector = rq->bio->bi_sector;
> rq->current_nr_sectors = bio_iovec(rq->bio)->bv_len >> 9;
> rq->hard_cur_sectors = rq->current_nr_sectors;
> rq->buffer = bio_data(rq->bio);
> out:
> return ret;
>
>
> Is how the code should look at the end of ide_dma_timeout_retry (plus
> your rq == NULL check I imagine)

The only difference with the code in 2.6.10 (ide-io.c is currently
unchanged in bk9) is rq->buffer is set to NULL instead of
bio_data(rq->bio)... I suppose this is the corruption fix?

Simon-
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/