Re: [PATCH] fs: Restore files_lock and set_fs_root exports

[Christoph Hellwig]

On Thu, Jan 06, 2005 at 04:24:58PM -0800, Linus Torvalds wrote:
> At that point there is a specific _reason_ to break it, aka "that function 
> simply doesn't exist any more".
> 
> I'm known for happily breaking binary modules, but I think we should do it 
> only if we have a reason _other_ than "let's break a module". 

Note that the function that started this thread weren't removed with nwfs
in mind - in fact I doubt anyone here has seen the module or it's
requirements.

Arjan and I have produced lists of unused exported symbols and went through
the list what made sense and what not, and these exports were up high on the
doesn't make sense and any use we could imagine would be harmfull list.

The explained use only seconds that opinion - it has caused constant trouble
for years where IBM has been pushing the big distros to relax VFS sanity
checks and add additioal exports for their totally broken kernel driver.

That no beeing enough I know of at least two propritary Unix variants where
it cause exactly the same trouble.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/