Re: [PATCH] ALPS touchpad detection fix

[Denis Vlasenko]

On Thursday 06 January 2005 18:54, Peter Osterlund wrote:
> My ALPS touchpad is not recognized because the device gets confused by
> the Kensington ThinkingMouse probe.  It responds with "00 00 14"
> instead of the expected "00 00 64" to the "E6 report".
> 
> Resetting the device before attempting the ALPS probe fixes the
> problem.
> 
> Signed-off-by: Peter Osterlund <petero2@xxxxxxxxx>
> ---
> 
>  linux-petero/drivers/input/mouse/psmouse-base.c |    1 +
>  1 files changed, 1 insertion(+)
> 
> diff -puN drivers/input/mouse/psmouse-base.c~alps-fix drivers/input/mouse/psmouse-base.c
> --- linux/drivers/input/mouse/psmouse-base.c~alps-fix	2005-01-06 17:33:15.000000000 +0100
> +++ linux-petero/drivers/input/mouse/psmouse-base.c	2005-01-06 17:33:46.000000000 +0100
> @@ -451,6 +451,7 @@ static int psmouse_extensions(struct psm
>  /*
>   * Try ALPS TouchPad
>   */
> +	ps2_command(&psmouse->ps2dev, NULL, PSMOUSE_CMD_RESET_DIS);
>  	if (max_proto > PSMOUSE_IMEX && alps_detect(psmouse, set_properties) == 0) {
>  		if (!set_properties || alps_init(psmouse) == 0)
>  			return PSMOUSE_ALPS;

You do reset even if max_proto <= PSMOUSE_IMEX and therefore
alps_detect won't be called. Is it intended?
--
vda

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/