Re: [PATCH] kill symbol_get & friends

From: Rusty Russell
Date: Wed Jan 12 2005 - 19:49:59 EST


On Wed, 2005-01-12 at 21:31 +0100, Christoph Hellwig wrote:
> Rusty introduced symbol_get as a replacement for inter_module_get, but
> it doesn't really solved the underlying problem.

Sorry, Christoph, I must be particularly obtuse today.

If you don't hold a reference, then yes, the module can go away. This
hasn't been a huge problem for users in the past.

The lack of users is because, firstly, dynamic dependencies are less
common than static ones, and secondly because the remaining inter-module
users (AGP and mtd) have not been converted. Patches have been sent
several times, but maintainers are distracted, it seems. I *will* run
out of patience and push those patches which take away intermodule.c one
day (hint, hint!).

For optional module dependencies, weak symbols can be used, but there
seems to be a desire for genuine dynamic dependencies. If you can get
rid of those, I'll apply your patch in a second!

Cheers,
Rusty.
--
A bad analogy is like a leaky screwdriver -- Richard Braakman

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/