Re: [PATCH] support for gzipped (ELF) core dumps

From: Jan Frey
Date: Thu Jan 13 2005 - 06:54:54 EST


Hi,

I tried to use those "in-kernel" functions, but they seem to do little
different CRC calculations. Unfortunately I don't have any experiences
with CRC stuff, anyone able to help here?

Regards,
Jan

> >+/* This table is needed for efficient CRC32 calculation */
> >+static const unsigned long crc_table[8][256] = {
> >+ {
> >+ 0x00000000UL, 0x77073096UL, 0xee0e612cUL, 0x990951baUL, 0x076dc419UL,
>
> First, by using "unsigned long", you may be doubling the size on most 64 bit
> platforms. Second, I'm pretty sure there is a standard implementation of
> several CRCs already in the kernel - is there a reason not to use one of them
> (e.g. a different polynomial)?
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/