Re: [PATCH] PPC64: 32bit wrapper for ioctls.

From: Arnd Bergmann
Date: Fri Jan 14 2005 - 04:33:24 EST


On Dunnersdag 13 Januar 2005 19:46, Mike Wolf wrote:
> Hi Paul,
>   The patch adds some 32bit wrappers for 2 ioctls that Java needs.
> Assuming this doesn't generate a round of discussion, please
> forward upstream to akpm/torvalds.

Why add them to arch/ppc64? These don't look architecture specific, so they
should go into include/linux/compat_ioctl.h.

> --- linus-0112.orig/arch/ppc64/kernel/ioctl32.c 2005-01-13 10:35:10.165539000 -0600
> +++ linus-0112/arch/ppc64/kernel/ioctl32.c      2005-01-13 10:51:43.450433277 -0600
> @@ -43,6 +43,8 @@
>  COMPATIBLE_IOCTL(TIOCSTART)
>  COMPATIBLE_IOCTL(TIOCSTOP)
>  COMPATIBLE_IOCTL(TIOCSLTC)
> +COMPATIBLE_IOCTL(TIOCMIWAIT)

Note that TIOCMIWAIT is not COMPATIBLE_IOCTL, but ULONG_IOCTL. It doesn't make
a difference for ppc64, but if you add it to the generic file that is needed for
s390x.

Arnd <><


Attachment: pgp00000.pgp
Description: signature