Re: Screwy clock after apm suspend

From: Mikael Pettersson
Date: Sat Jan 15 2005 - 13:32:27 EST


On Tue, 11 Jan 2005 14:10:19 +0100, Pavel Machek wrote:
>> > Looking harder, in arch/i386/kernel/apm.c the system time is also
>> > saved and restored in a very similar way to timer_suspend/resume.
>> > Would this account for the time drift in APM mode? (sleep time being
>> > accounted for twice?)
>>
>> No, apm.c's update to xtime is absolute, just like time.c's.
>> Doing both is pointless but not harmful. (I've already tried
>> with apm.c's xtime update commented out, but the time-warp
>> bug remained.)
>>
>> My 0.02 SEK says it's the jiffies update that's broken.
>
>Okay, can you
>
>* kill jiffie update (x86-64, too)
>* remove apm.c variant
>* test it (or make someone test it) with apm?
>
>I now see the drift with acpi, too :-(. I can do the acpi testing...

I'm no longer seeing any time jumps after resumes with the
2.6.11-rc1 kernel. It looks like the wall_jiffies change in
time.c fixed the bug.

/Mikael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/