Re: [PATCH 4/13] FAT: Return better error codes fromvfat_valid_longname()

From: OGAWA Hirofumi
Date: Mon Jan 17 2005 - 21:31:53 EST


Rogério Brito <rbrito@xxxxxxxxxx> writes:

> On Jan 18 2005, OGAWA Hirofumi wrote:
>> static int vfat_valid_longname(const unsigned char *name, unsigned int len)
>> {
>> - if (len && name[len-1] == ' ')
>> - return 0;
>> + if (name[len - 1] == ' ')
>> + return -EINVAL;
>
> Sorry for the stupid question, but is len guaranteed to be always greater
> than zero?

Yes. That "len" was already checked in vfat_add_entry().

Thanks.
--
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/