Re: crypto/api.c: crypto_alg_available(): flags param not used.

From: James Morris
Date: Thu Jan 20 2005 - 09:56:39 EST


On Thu, 20 Jan 2005, Kausty wrote:

> hi
> A small observation. In crypto/api.c in linux-2.6.8.1
>
> The function:
> int crypto_alg_available(const char *name, u32 flags)
>
> has a flags param which does not seem to be used.
>
> though it does not matter much but has this been fixed in later releases?
> xfrm functions in ipsec do call this function but always with flags as 0.
>
> Thanks and regards
> kausty

IIRC, this was to allow future code to specify preferences for the type of
algorithm driver (e.g. hardware), but has not been used. This is an
example of why it's a bad idea to add infrastructure which isn't being
used at the time.


- James
--
James Morris
<jmorris@xxxxxxxxxx>


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/