Re: [PATCH] ppc32: fix powersave with interrupts disabled

From: Benjamin Herrenschmidt
Date: Mon Jan 24 2005 - 21:41:05 EST


On Mon, 2005-01-24 at 15:51 -0600, Kumar Gala wrote:
> It looks like the problem has to do with entering the powersave routine
> with irqs disabled. Here is a patch that will only enter powersave if irqs
> are enabled.
>
> Entering powersave on PPC while irqs are disabled causes a hang. Only
> enter powersave if irqs are disabled.

I have a different fix which is to re-enable them (basically to move the
local_irq_disable we do in #ifdef CONFIG_SMP above the whole block,
removing the #else case).

I'm waiting for Ingo's ack about what exact race he's trying to fix
though...

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/