Re: [PATCH] Enforce USB interface claims

[Duncan Sands]

> > -	/* if not yet claimed, claim it for the driver */
> > -	dev_warn(&ps->dev->dev, "usbfs: process %d (%s) did not claim interface %u before use\n",
> > -	       current->pid, current->comm, ifnum);
> > -	return claimintf(ps, ifnum);
> > +	return -EINVAL;
> >  }
> >  
> >  static int findintfep(struct usb_device *dev, unsigned int ep)
> 
> 
> Um, why?  I think this is there to help with "broken" userspace code
> that was written before we enforced the rules of "you must claim an
> interface before using it."  As such, I don't think we can apply this
> patch.

Unfortunately it also means that there is no pressure to fix the user-space
code.  How about having it say that the autoclaiming is deprecated, and will
be removed at some point?

Ciao,

Duncan.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/