Re: Enable swsusp on SMP machines

[Pavel Machek]

Hi!

> > -	/* Suspend is hard to get right on SMP. */
> > -	if (num_online_cpus() != 1) {
> > -		error = -EPERM;
> > +	if (state == PM_SUSPEND_DISK) {
> > +		error = pm_suspend_disk();
> >  		goto Unlock;
> >  	}
> >  
> > -	if (state == PM_SUSPEND_DISK) {
> > -		error = pm_suspend_disk();
> > +	/* Suspend is hard to get right on SMP. */
> > +	if (num_online_cpus() != 1) {
> > +		error = -EPERM;
> >  		goto Unlock;
> >  	}
> 
> Are you sure about this?

Yes, as we already agreed on in private mails ;-). The diff really is
confusing.
								Pavel
-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/