Re: [PATCH 2.6.11-rc2] I2C: lm80 driver improvement (From Aurelien)- Resubmit

From: Aurélien Jarno
Date: Wed Jan 26 2005 - 21:56:22 EST


Greg KH wrote:
On Wed, Jan 26, 2005 at 02:57:35AM -0500, Shawn Starr wrote:

static inline unsigned char FAN_TO_REG(unsigned rpm, unsigned div)
{
- if (rpm == 0)
+ if (rpm <= 0)


As was pointed out, this doesn't make any sense.

Care to redo the patch?
Please note that the problem is not present in the lm78 patch as the argument is of type int.

Aurelien

--
.''`. Aurelien Jarno GPG: 1024D/F1BCDB73
: :' : Debian GNU/Linux developer | Electrical Engineer
`. `' aurel32@xxxxxxxxxx | aurelien@xxxxxxxxxxx
`- people.debian.org/~aurel32 | www.aurel32.net
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/