Re: [PATCH] SHA1 clarify kerneldoc

From: Matt Mackall
Date: Thu Jan 27 2005 - 14:30:36 EST


On Thu, Jan 27, 2005 at 01:22:28PM -0500, Bill Davidsen wrote:
> > *
> > * This function generates a SHA1 digest for a single. Be warned, it
> ^^^^^^
> Is this a term I don't know, "single" as a noun, or should "512 bit
> block" follow, as it does in crypto/sha1 from rc1-bk1 which is what I
> have handy?

That'll teach me to add comments.

Signed-off-by: Matt Mackall <mpm@xxxxxxxxxxx>

Index: rc2mm1/lib/sha1.c
===================================================================
--- rc2mm1.orig/lib/sha1.c 2005-01-27 11:24:23.000000000 -0800
+++ rc2mm1/lib/sha1.c 2005-01-27 11:25:19.000000000 -0800
@@ -27,9 +27,10 @@
* @data: 512 bits of data to hash
* @W: 80 words of workspace (see note)
*
- * This function generates a SHA1 digest for a single. Be warned, it
- * does not handle padding and message digest, do not confuse it with
- * the full FIPS 180-1 digest algorithm for variable length messages.
+ * This function generates a SHA1 digest for a single 512-bit block.
+ * Be warned, it does not handle padding and message digest, do not
+ * confuse it with the full FIPS 180-1 digest algorithm for variable
+ * length messages.
*
* Note: If the hash is security sensitive, the caller should be sure
* to clear the workspace. This is left to the caller to avoid


--
Mathematics is the supreme nostalgia of our time.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/