Re: [PATCH] Add CONFIG_X86_APIC_OFF for i386/UP

From: Andi Kleen
Date: Fri Jan 28 2005 - 13:08:56 EST


On Fri, Jan 28, 2005 at 10:43:42AM -0700, Zwane Mwaikambo wrote:
> On Fri, 28 Jan 2005, Andi Kleen wrote:
>
> > > Forgive me for not wading through the code, but it really needs to
> > > be spelt out in the comments: what's wrong with the existing kernel,
> > > with "noapic nolapic" in the distro's bootstring by default?
> >
> > It's harder to explain and traditionally in LILO you couldn't remove
> > any options (in grub you can now). I think it makes much more sense
> > to have an positive option for this too, not a negative one.
>
> Well new distributions with 2.6 most probably aren't using LILO and if
> you're running 2.6 with some ancient distro you can add commandline
> options yourself.

Ok, thanks for the constructive feedback. I withdraw the patch then
and will continue to maintain it in private.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/