Re: ptrace single-stepping change breaks Wine

[Kari Hurtta]

[ Reading just long long thread (actually from
gmane.comp.emulators.wine.devel) ]

<Pine.LNX.4.58.0412302141320.2280@xxxxxxxxxxxxxxx>
Linus Torvalds <torvalds@xxxxxxxx>:

> +
> +		/*
> +		 * Was the TF flag set by a debugger? If so, clear it now,
> +		 * so that register information is correct.
> +		 */
> +		if (tsk->ptrace & PT_DTRACE) {
> +			regs->eflags &= ~TF_MASK;
> +			tsk->ptrace &= ~PT_DTRACE;
                        =========================
> +			if (!tsk->ptrace & PT_DTRACE)
                             =======================
> +				goto clear_TF;
> +		}
>  	}

Perhaps, I'm stupid.

But is there something strange on that test of tsk->ptrace variable?

Before that PT_DTRACE was cleared from that same tsk->ptrace variable.

/ Kari Hurtta
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/