Re: Memory leak in 2.6.11-rc1?

[Patrick McHardy]

Patrick McHardy wrote:

> Russell King wrote:
>
> > I don't know if the code is using fragment lists in ip_fragment(), but
> > on reading the code a question comes to mind: if we have a list of
> > fragments, does each fragment skb have a valid (and refcounted) dst
> > pointer before ip_fragment() does it's job?  If yes, then isn't the
> > first ip_copy_metadata() in ip_fragment() going to overwrite this
> > pointer without dropping the refcount?
> Nice spotting. If conntrack isn't loaded defragmentation happens after
> routing, so this is likely the cause.

OTOH, if conntrack isn't loaded forwarded packet are never defragmented,
so frag_list should be empty. So probably false alarm, sorry.

> Regards
> Patrick



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/