Re: [Discuss][i386] Platform SMIs and their interferance with tsc based delay calibration

[Martin Wilck]

Linus Torvalds wrote:

> In particular, I don't see why you didn't just put this in the generic 
> calibrate_delay() routine. You seem to have basically duplicated it, and 
> added the "guess from an external timer" code - and I don't see what's 
> non-generic about that, except for some trivial "what's the current timer" 
> lookup.

The trivial lookup is hidden in the __delay() function. Making it return 
the number of "loops" it actually waited would help having a robust 
generic code.

Regards
Martin
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/