Re: [PATCH] ppc64: Implement a vDSO and use it for signal trampoline

[Sam Ravnborg]

> Index: linux-work/arch/ppc64/kernel/vdso32/Makefile
> ===================================================================
> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ linux-work/arch/ppc64/kernel/vdso32/Makefile	2005-01-31 16:25:56.000000000 +1100
> @@ -0,0 +1,50 @@
> +# Choose compiler
> +#
> +# XXX FIXME: We probably want to enforce using a biarch compiler by default
> +#             and thus use (CC) with -m64, while letting the user pass a
> +#             CROSS32_COMPILE prefix if wanted. Same goes for the zImage
> +#             wrappers
> +#
> +
> +CROSS32_COMPILE ?=
> +
> +CROSS32CC		:= $(CROSS32_COMPILE)gcc
> +CROSS32AS		:= $(CROSS32_COMPILE)as
This needs to go into arch/ppc64/Makefile

> +
> +# List of files in the vdso, has to be asm only for now
> +
> +src-vdso32 = sigtramp.S gettimeofday.S datapage.S cacheflush.S

It is normal kbuild practice to list .o files.
So it would be:

obj-vdso32 := sigtramp.o gettimeofday.o datapage.o cacheflush.o
targets    := $(obj-vdso32)
obj-vdso32 := $(addprefix $(obj)/, $(obj-vdso32))

One line saved compared to below (not counting the src-vdso32 assignment
that is unused).
Also notice that ':=' uses all over. No need to use late evaluation when
no dynamic references are used ($ $@ etc.).

> +# Build rules
> +
> +obj-vdso32 := $(addsuffix .o, $(basename $(src-vdso32)))
> +targets := $(obj-vdso32) vdso32.so
> +obj-vdso32 := $(addprefix $(obj)/, $(obj-vdso32))
> +src-vdso32 := $(addprefix $(src)/, $(src-vdso32))


Same comments to the vdso64/Makefile

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/