Re: [PATCH 2.6] 7/7 replace snd_kmalloc_strdup by kstrdup

[Takashi Iwai]

At Tue, 01 Feb 2005 12:27:44 +0000,
Paulo Marques wrote:
> 
> Takashi Iwai wrote:
> > At Tue,  1 Feb 2005 03:28:46 +0000,
> > "" <pmarques@xxxxxxxxxxxx> wrote:
> > 
> >>[1  <text/plain; iso-8859-1 (quoted-printable)>]
> >>
> >>This patch removes the strdup implementation from the sound core
> >>(snd_kmalloc_strdup), and updates it to use the kstrdup library function.
> >>
> >>Signed-off-by: Paulo Marques <pmarques@xxxxxxxxxxxx>
> > 
> > 
> > This patch won't work properly if CONFIG_SND_DEBUG_MEMORY is set...
> 
> Humm.. compiles ok here.
> 
> I just rebuilt a vanilla 2.6.11-rc2-bk9 tree, applied the patches, 
> selected CONFIG_SND_DEBUG and CONFIG_SND_DEBUG_MEMORY, and it compiled 
> just fine.
> 
> I had already tested the patches with an allyesconfig, but tested it 
> anyway just to be sure.
> 
> Are you sure you also applied the first patch in the series that creates 
> the kstrdup library function? If you are, can you send me your .config 
> so that I can test it here?

The compile should be fine but it may result in memory corruption
since kmalloc/kfree become wrappers when CONFIG_SND_DEBUG_MEMORY is
set.  See include/sound/core.h.


Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/