Re: [PATCH] Prevent NMI oopser

From: Vasily Averin
Date: Wed Feb 02 2005 - 15:04:09 EST


Hello Matt

Matt Domsch wrote:
On Wed, Feb 02, 2005 at 09:42:02PM +0300, Vasily Averin wrote:
This is megaraid2 driver update (2.10.8.2 version, latest 2.4-compatible
version that I've seen), taken from latest RHEL3 kernel update. I
believe it should prevent NMI in abort/reset handler.

Thanks Vasily, I was just looking at this again yesterday.

You'll also find that because the driver doesn't define its inline
functions prior to their use, newest compilers refuse to compile this
version of the driver. Earlier compilers just ignore it and don't
inline anything.

As a hack, one could #define inline /*nothing*/ in megaraid2.h to
avoid this, but it would be nice if the functions could all get
reordered such that inlining works properly, and the need for function
declarations in megaraid2.h would disappear completely.

Could you fix it by additional patch? Or do you going to prepare a new one?

Thank you,
Vasily Averin, SWSoft Linux Kernel Team

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/