Re: [PATCH] PPC/PPC64: Introduce CPU_HAS_FEATURE() macro

From: Pekka Enberg
Date: Fri Feb 04 2005 - 03:22:54 EST


Hi,

On Fri, 4 Feb 2005 01:22:54 -0600, Olof Johansson <olof@xxxxxxxxxxxxxx> wrote:
> +#define CPU_HAS_FEATURE(x) (cur_cpu_spec->cpu_features & CPU_FTR_##x)
> +

Please drop the CPU_FTR_##x macro magic as it makes grepping more
complicated. If the enum names are too long, just do s/CPU_FTR_/CPU_/g
or something similar. Also, could you please make this a static inline
function?

Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/