Re: 2.6.11-rc3-mm1 - broken bttv ?

[Paulo Marques]

Paulo Marques wrote:
> jjluza wrote:
>
> > Eyal Lebedinsky wrote
> >
> > > I am having bttv problems with vanilla -rc3. Does it work for you?
> >
> >
> >
> > I don't know, as I said I didn't test kernel between 2.6.10 and 
> > 2.6.11-rc3-mm1.
> > Sorry.
> > If I have time enough later, I can test 2.6.11-rc3.
> > Since I don't really know if it's the good place to talk about that, I 
> > decided to report this bug on bugzilla too. Maybe you can post your 
> > problem here :
> > http://bugzilla.kernel.org/show_bug.cgi?id=4171
>
>
> Other people with similar problems reported that the attached patch from 
>  Gerd Knorr fixed the problem for them.

-ENOATTACHMENT  :P

--
Paulo Marques - www.grupopie.com

All that is necessary for the triumph of evil is that good men do nothing.
Edmund Burke (1729 - 1797)
--- linux-2.6.11-rc3/drivers/media/video/tda9887.c
+++ linux-2.6.11-rc3/drivers/media/video/tda9887.c
@@ -545,19 +553,21 @@
 	int rc;
 
 	memset(buf,0,sizeof(buf));
+	tda9887_set_tvnorm(t,buf);
 	buf[1] |= cOutputPort1Inactive;
 	buf[1] |= cOutputPort2Inactive;
-	tda9887_set_tvnorm(t,buf);
 	if (UNSET != t->pinnacle_id) {
 		tda9887_set_pinnacle(t,buf);
 	}
 	tda9887_set_config(t,buf);
 	tda9887_set_insmod(t,buf);
 
+#if 0
 	if (t->std & V4L2_STD_SECAM_L) {
 		/* secam fixup (FIXME: move this to tvnorms array?) */
 		buf[1] &= ~cOutputPort2Inactive;
 	}
+#endif
 
 	dprintk(PREFIX "writing: b=0x%02x c=0x%02x e=0x%02x\n",
 		buf[1],buf[2],buf[3]);