Re: move-accounting-function-calls-out-of-critical-vm-code-paths.patch

From: Jay Lan
Date: Mon Feb 07 2005 - 09:12:27 EST


Andrew Morton wrote:
Christoph Lameter <clameter@xxxxxxx> wrote:

I hope that Roland's changes for higher resolution of cputime would
make that possible. But this is Jay's thing not mine. I just want to make
sure that the CSA patches does not get in the way of our attempts to
improve the performance of the page fault handler. In the discussions on
linux-mm there was also some concern about adding these calls.


Well your patch certainly cleans things up in there and would be a good
thing to have as long as we can be sure that it doesn't break the
accounting in some subtle way.

Which implies that we need to see some additional accounting code, so we
can verify that the base accumulation infrastructure is doing the expected
thing. As well as an ack from the interested parties. Does anyone know
what's happening with all the new accounting initiatives? I'm seeing no
activity at all.

Sorry guys! I have been away for three weeks on short term disability.:(

I have tested Christoph's patch before the leave. It did work for CSA
and showed performance improvement on certain configuration.

CSA is currently implemented as a loadable module. I think ELSA is the
same, right? The use of the enhanced accounting data collection
code is not in the kernel tree. That was why Andrew did not see usage of the accounting patches. Should i propose to include the CSA module in
the kernel then, Andrew? :)

Cheers,
- jay


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/