Re: udev::cdsymlinks does not consider a 'cdrw' as a 'cdrom'

[J.A. Magallon]

On 2005.02.12, J.A. Magallon wrote:
> 
> On 2005.02.12, J.A. Magallon wrote:
> > Hi...
> > 
> > I have a little problem with udev. I have udev-051, but have tried
> > cdsymlinks.c from 053 and is the same.
> > 
> > It does not give 'cdrom' or 'dvd' for DVD writers.
> > In one box, hdb is a DVD, and hdc is a DVDRW:
> > 
> 
> Opps, and cdsymlinks.c and .sh behave different:
> 
> werewolf:~# /sbin/cdsymlinks hdc -d
> Devices: hdb hdc
> DVDRAM : 0 1 hdc
> DVDRW  : 0 1 hdc
> DVD    : 1 1 hdb hdc
> CDRW   : 0 1 hdc
> CDR    : 0 1 hdc
> CDWMRW :
> CDMRW  :
> CDROM  : (all) hdb hdc
>  cdrw dvdrw dvdram
> 
> werewolf:~# /etc/udev/scripts/cdsymlinks.sh hdc -d
> Devices: hdb hdc
> DVDRAM : 0 1 hdc
> DVDRW  : 0 1 hdc
> DVD    : 1 1 hdb hdc
> CDRW   : 0 1 hdc
> CD-R   : 0 1 hdc
> CDMRW  : 1 1 hdb hdc
> CDM    : 1 1 hdb hdc
> CDROM  : (all) hdb hdc
>  cdrom1 cdrw dvd1 dvdrw dvdram
> 


Caught it:

--- cdsymlinks.c.orig	2005-02-12 02:17:19.000000000 +0100
+++ cdsymlinks.c	2005-02-12 02:17:26.000000000 +0100
@@ -267,8 +267,8 @@
             list_delete (&allowed_output);
             list_assign_split (&allowed_output, p.we_wordv[0] + 7);
           }
-          else if (!strncmp (p.we_wordv[0], "NUMBERED_LINKS=", 14))
-            numbered_links = atoi (p.we_wordv[0] + 14);
+          else if (!strncmp (p.we_wordv[0], "NUMBERED_LINKS=", 15))
+            numbered_links = atoi (p.we_wordv[0] + 15);
           break;
 	}
 	/* fall through */


--
J.A. Magallon <jamagallon()able!es>     \               Software is like sex:
werewolf!able!es                         \         It's better when it's free
Mandrakelinux release 10.2 (Cooker) for i586
Linux 2.6.10-jam9 (gcc 3.4.3 (Mandrakelinux 10.2 3.4.3-3mdk)) #1

Attachment: pgp00000.pgp
Description: PGP signature