[PATCH] Check for wraps in copy_page_range

From: Benjamin Herrenschmidt
Date: Thu Feb 17 2005 - 02:23:34 EST


Hi !

While browsing the 4 level page table changes (looking for a bug), I
noticed that copy_page_range, unlike others, do not check for
wraparound, which I suppose could be a problem with 4G/4G architectures
or that sort of thing.

This patch fixes it.

Signed-off-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>

Index: linux-work/mm/memory.c
===================================================================
--- linux-work.orig/mm/memory.c 2005-02-03 15:48:17.000000000 +1100
+++ linux-work/mm/memory.c 2005-02-16 14:51:37.000000000 +1100
@@ -358,7 +358,7 @@

for (; addr < end; addr = next, src_pmd++, dst_pmd++) {
next = (addr + PMD_SIZE) & PMD_MASK;
- if (next > end)
+ if (next > end || next <= addr)
next = end;
if (pmd_none(*src_pmd))
continue;
@@ -390,7 +390,7 @@

for (; addr < end; addr = next, src_pud++, dst_pud++) {
next = (addr + PUD_SIZE) & PUD_MASK;
- if (next > end)
+ if (next > end || next <= addr)
next = end;
if (pud_none(*src_pud))
continue;



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/