Re: [PATCH] Fix buf in zeromap_pud_range() losing virtual address

[Andi Kleen]

Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> writes:
>
> zeromap_pud_range() is one of these page tables walking functions that
> split the address into a base and an offset. It forgets to add back the
> "base" when calling the lower level zeromap_pmd_range(), thus passing a
> bogus virtual address. Most archs won't care, unless they do the above,
> since the lower level can allocate a PTE page.

Hmm, there might be even more cases of this. I remember pondering
it when I did the original 4 level work (sometimes we discard higher level 
virtual address bits during walking)

> (Note: We are in _urgent_ need to consolidate all those page table
> walking functions, they all do things in a subtely different way, with
> different checks (sometimes redudant) and inconsitent with each other,
> even within a given set of them. Hopefully, Nick has some work in
> progress there).

I have. But it will just make them more similar, not completely consolidate
them into an iterator, because that's too hard/ugly to do efficiently.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/