Re: [PATCH 2/2] page table iterators

From: Andi Kleen
Date: Thu Feb 17 2005 - 18:41:18 EST


On Fri, Feb 18, 2005 at 10:21:03AM +1100, Benjamin Herrenschmidt wrote:
> On Fri, 2005-02-18 at 00:03 +0100, Andi Kleen wrote:
>
> > And to be honest we only have about 6 or 7 of these walkers
> > in the whole kernel. And 90% of them are in memory.c
> > While doing 4level I think I changed all of them around several
> > times and it wasn't that big an issue. So it's not that we
> > have a big pressing problem here...
>
> We have about 50% of them in memory.c :) But my main problem is more
> that every single of them is implemented slightly differently.

No much more. But I only count real walkers, not stuff like vmalloc.

The ioremap duplication over architectures is a bit annoying, but
the fix for that would be to factor the code out completely, not
only improve walking.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/