Re: [2.6 patch] drivers/net/shaper.c: make a variable static

[Adrian Bunk]

On Fri, Feb 18, 2005 at 07:18:19PM -0500, Jeff Garzik wrote:
> Adrian Bunk wrote:
> >This patch contains the following cleanups:
> >- remove an unused #define SHAPER_BANNER
> >- remove the sh_debug flag
> >
> >Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>
> 
> you are removing presumably-useful debug code; NAK.

OK, less invasive patch below.


<--  snip  -->


This patch makes a needlessly global variable static.

Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>

--- linux-2.6.11-rc3-mm2-full/drivers/net/shaper.c.old	2005-02-16 18:20:33.000000000 +0100
+++ linux-2.6.11-rc3-mm2-full/drivers/net/shaper.c	2005-02-19 09:27:53.000000000 +0100
@@ -96,7 +96,7 @@
 }; 
 #define SHAPERCB(skb) ((struct shaper_cb *) ((skb)->cb))
 
-int sh_debug;		/* Debug flag */
+static int sh_debug;		/* Debug flag */
 
 #define SHAPER_BANNER	"CymruNet Traffic Shaper BETA 0.04 for Linux 2.1\n"
 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/