Re: 2.6.11-rc4-mm1 (VFS: Cannot open root device "301")

[Andrew Morton]

Steven Cole <elenstev@xxxxxxxxxxx> wrote:
>
> > Yes, that worked.  2.6.11-rc4-mm1 now boots OK, but hdb1 seems to be 
> > missing.

Looking at the IDE update in rc4-mm1:

+void ide_init_disk(struct gendisk *disk, ide_drive_t *drive)
+{
+	ide_hwif_t *hwif = drive->hwif;
+	unsigned int unit = drive->select.all & (1 << 4);
+
+	disk->major = hwif->major;
+	disk->first_minor = unit << PARTN_BITS;
+	sprintf(disk->disk_name, "hd%c", 'a' + hwif->index * MAX_DRIVES + unit);
+	disk->queue = drive->queue;
+}

Looks funny.

Could someone try this?

-	unsigned int unit = drive->select.all & (1 << 4);
+	unsigned int unit = (drive->select.all >> 4) & 1;


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/