Re: [PATCH] [i2c]: Fix some gcc 4.0 compile failures and warnings

From: Greg KH
Date: Fri Feb 25 2005 - 15:10:52 EST


On Wed, Feb 23, 2005 at 02:12:44PM -0800, Mickey Stein wrote:
> From: Mickey Stein
> Versions: linux-2.6.11-rc4-bk11, gcc4 (GCC) 4.0.0 20050217 (latest fc
> rawhide from 19Feb DL)
>
> gcc 4.0.x cvs seems to dislike "include/linux/i2c.h file" and others
> due to a current gcc 4.0.x change having to do with
> array declarations.
>
> Example error msg: include/linux/i2c.h:{55,194} error: array type has
> incomplete element type
>
> A. Daplas has recently done a workaround for this on another header
> file. A thread discussing this
> can be found by following the link below:
>
> http://gcc.gnu.org/ml/gcc/2005-02/msg00053.html
>
> The patch changes the array(struct i2c_msg) declaration used by
> *i2c_transfer and *master_xfer
> from "struct i2c_msg msg[]" format to "struct i2c_msg *msg".
>
> After some grepping, I came up with about a dozen files that used the
> format disliked by gcc4 that're addressed by the attached patch.
> Tested on gcc 3.x & gcc 4.x by configuring kernel with all i2c switches
> enabled as module, and saw no errors or warnings in i2c.
>
> Signed-off-by: Mickey Stein <yekkim@xxxxxxxxxxx>

Applied, thanks.

greg k-h

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/